OnActorDead - was it the player?

[Yo-Yo]

I'm trying to determine if when an aricraft/actor is shot down if the player was involved.

My thought is that the onActorDead provides the actor that died, but also a list of damage initiators and the score and time for each of these? I seem to be able to count these from the 'list' but am stuck trying to loop through the list with a 'foreach'. I have never used a C# list before so might be totally wrong on what I'm attempting.

So count works, I think:

 public override void OnActorDead(int missionNumber, string shortName, maddox.game.world.AiActor actor, System.Collections.Generic.List<maddox.game.world.DamagerScore> damages)
    {
        
        Console.WriteLine("" + shortName + " is dead actor");


            Console.WriteLine("Count " + damages.Count);


    }

But if I try this to hopefully go through each score value (I actually intend to check the initiators if one is the player but am trying to just start with the score values as practice on getting something from the list):

  public override void OnActorDead(int missionNumber, string shortName, maddox.game.world.AiActor actor, System.Collections.Generic.List<maddox.game.world.DamagerScore> damages)
    {
        
        Console.WriteLine("" + shortName + " is dead actor");


        //Console.WriteLine("Count " + damages.Count);

        foreach (double s in damages)
            Console.WriteLine(s);


    }

I get an errror in the script compiler saying: Cannot convert type 'maddox.game.world.DamagerScore' to 'double'

but if I see correctly in my object browser the DamagerScore method is like this: public DamagerScore(maddox.game.world.AiDamageInitiator i, double s, double t)


Am I even close? Is there an easy way to check if a dead/killed/destroyed aircraft(actor) was damaged by the player?

[ATAG_Colander]

Try this:

foreach(maddox.game.world.DamagerScore damage in damages)
{
Now do something with  "damage.whatever"
...
}

[Sleepy_Fly]

But if I try this to hopefully go through each score value (I actually intend to check the initiators if one is the player but am trying to just start with the score values as practice on getting something from the list):

  public override void OnActorDead(int missionNumber, string shortName, maddox.game.world.AiActor actor, System.Collections.Generic.List<maddox.game.world.DamagerScore> damages)
    {
        
        Console.WriteLine("" + shortName + " is dead actor");


        //Console.WriteLine("Count " + damages.Count);

        foreach (double s in damages)
            Console.WriteLine(s);


    }

maddox.game.world.DamagerScore objects expose those properties :

initiator : as AiDamageInitiator
score : as double
time : as double

So, your code could be like :

  public override void OnActorDead(int missionNumber, string shortName, maddox.game.world.AiActor actor, System.Collections.Generic.List<maddox.game.world.DamagerScore> damages)
    {
        
        Console.WriteLine("" + shortName + " is dead actor");


        //Console.WriteLine("Count " + damages.Count);

        foreach ((maddox.game.world.DamagerScore)objDamage in damages)
            Console.WriteLine(objDamage.score);


    }

This is lunch time so I have no time to test yet.

[Sleepy_Fly]

BTW, I use this tool :

https://www.jetbrains.com/decompiler/

Very useful to discover interfaces of classes, inheritances, subtypes and more.

[Yo-Yo]

Thanks both, that should be enough for me to go on for now. Appreciated.

[Yo-Yo]

BTW, I use this tool :

https://www.jetbrains.com/decompiler/

Very useful to discover interfaces of classes, inheritances, subtypes and more.

Oh that seems very usefiul indeed. Will take me a while to get my head around it but I think that allows me to see much of the stuff I was generally banging my head over repeatedly.

[Sleepy_Fly]

Oh that seems very usefiul indeed. Will take me a while to get my head around it but I think that allows me to see much of the stuff I was generally banging my head over repeatedly.

(un)fortunately, the core code is obfuscated

[ATAG_Oskar]

        foreach (DamagerScore ds in damages)
        {
            if (ds.initiator.Player != null) {
                // check Player name
            }
        }

[Yo-Yo]

        foreach (DamagerScore ds in damages)
        {
            if (ds.initiator.Player != null) {
                // check Player name
            }
        }

Ooo nice! Thanks.

[GANIX]

Hi Yo-Yo,

the following snippet is from the mission script 'Mid-July1940_v10.cs'. I seem to remember that SNAFU wrote it sometime in the past (2011).
Thanks to SNAFU.

public override void OnActorDead(int missionNumber, string shortName, AiActor actor, List<DamagerScore> damages)
{
	base.OnActorDead(missionNumber, shortName, actor, damages);
	
//////////////////Penalty

	if (actor is AiPerson)
	{
		if ((actor as AiPerson).Player() != null)   // Player is Human
		{
			GamePlay.gpLogServer(null, "{0} - KIA", new object[] { (actor as AiPerson).Player() });
			PilotsInGame.AddDeathToPlayer((actor as AiPerson).Player());
		}
	}
	
//////////////////Namen Anzeigen beim zerstören von Bodeneineihten

	if ((actor as AiGroundActor) != null && damages[0].initiator.Player != null)
		GamePlay.gpLogServer(null, "{0} was destroyed by {1}", new object[] { (actor as AiCart).InternalTypeName().Substring(4), (damages[0].initiator.Player.Name()) });
	
///////////////////////////Punkte für zerstörte Einheiten	
	foreach (DamagerScore ds in damages)
	{
		int Addpoints = 0;
		int value;
		bool willReportDead = false;
		string TargetName = "";

		if (ds.initiator != null)
		{
			if (ds.initiator.Actor != null)
			{
				if (actor.Army() != ds.initiator.Actor.Army())
				{
					if (actor is AiPerson) break; // At moment Pilotkills are not counted ;)

					if (actor is AiAircraft)
					{

						if (PointsforAirTargets.TryGetValue((actor as AiAircraft).Type().ToString(), out value)) // Erstetzt wegen Stukaproblem
							Addpoints = PointsforAirTargets[(actor as AiAircraft).Type().ToString()];

						TargetName = SplitName((actor as AiAircraft).InternalTypeName());

						value = 0;
						if (actor.Army() == ArmyRed)
							{
							BlueAirKills++;
						if (RAFAvailableAirplanes.TryGetValue((actor as AiAircraft).InternalTypeName(), out value))
								{
							RAFAvailableAirplanes[(actor as AiAircraft).InternalTypeName()] = value - 1;
							TargetName += " (" + RAFAvailableAirplanes[(actor as AiAircraft).InternalTypeName()].ToString() + " available)";  // Shows Counter for Planetype
								}
							}
						
						else if (actor.Army() == ArmyBlue)
							{
							RedAirKills++;
						if (LWAvailableAirplanes.TryGetValue((actor as AiAircraft).InternalTypeName(), out value))
								{
							LWAvailableAirplanes[(actor as AiAircraft).InternalTypeName()] = value - 1;
							TargetName += " (" + LWAvailableAirplanes[(actor as AiAircraft).InternalTypeName()].ToString() + " available)";  // Shows Counter for Planetype
								}
							
							}
					}

					if (actor is AiGroundActor)
					{
						if (PointsforGroundTargets.TryGetValue((actor as AiGroundActor).Type(), out value))
							Addpoints = PointsforGroundTargets[(actor as AiGroundActor).Type()];

						TargetName = SplitName((actor as AiGroundActor).InternalTypeName());
					}

					
					willReportDead = true;

					if (ds.initiator.Actor.Army() == ArmyBlue)
					{
						BlueGrdKills++;
						ScoreBlue += Addpoints;
						if (Addpoints <=0)
						{ScoreBlue += 3;}
						GamePlay.gpLogServer(null, "Britisch {0} destroyed - Team scores now: RAF {1}- LW {2}", new object[] { TargetName, ScoreRed, ScoreBlue });
						break;
					}
					else if (ds.initiator.Actor.Army() == ArmyRed)
					{
						RedGrdKills++;
						ScoreRed += Addpoints;
						if (Addpoints <=0)
						{ScoreRed += 3;}
						GamePlay.gpLogServer(null, "German {0} destroyed - Team scores now: RAF {1}- LW {2}", new object[] { TargetName, ScoreRed, ScoreBlue });
						break;
					}
				}
			}
		}
	}    
}

[GANIX]

... and here another example by TheEnlightenedFlorist (TEF). I grabbed the snippet from 'TEF.dynCampaign.DynamicMission'.
Thanks to TheEnlightenedFlorist

EDIT: Here, the most interisting line for me is

<if (!base.GamePlay.gpPlayer().Place().IsAlive()) {...}>

public override void OnActorDead(int missionNumber, string shortName, AiActor actor, List<DamagerScore> damages)
{
	base.OnActorDead(missionNumber, shortName, actor, damages);
	if (!base.GamePlay.gpPlayer().Place().IsAlive())
	{
		playerDead = true;
	}
	if (actor == null || damages.Count <= 0)
	{
		return;
	}
	foreach (DamagerScore damage in damages)
	{
		if (damage.score > 0.5 && damage.initiator.Player != null)
		{
			player.addVictory(actor as AiAircraft);
		}
	}
}